[PATCH] staging/rdma/hfi1: Reduce number of parameters passed to send handlers

Leon Romanovsky leon at leon.nu
Wed Nov 11 06:25:35 UTC 2015


On Wed, Nov 11, 2015 at 12:34:37AM -0500, ira.weiny at intel.com wrote:
> From: Dennis Dalessandro <dennis.dalessandro at intel.com>
> 
> +int snoop_send_dma_handler(struct hfi1_qp *qp, struct hfi1_pkt_state *ps,
> +			   u64 pbc)
>  {
> -	pr_alert("Snooping/Capture of  Send DMA Packets Is Not Supported!\n");
> +	pr_alert("Snooping/Capture of Send DMA Packets Is Not Supported!\n");
>  	snoop_dbg("Unsupported Operation");
Is it really necessary to do both print alert to message log (pr_alert) and to
trace buffer (snoop_dbg)?


More information about the devel mailing list