[PATCH v2] staging/rdma/hfi1: Disable thermal polling before sensor initialization
Jubin John
jubin.john at intel.com
Thu Nov 5 23:36:25 UTC 2015
From: Jareer Abdel-Qader <jareer.h.abdel-qader at intel.com>
During driver load the thermal sensor needs to be reset prior
to initialization of the sensor. This prevents a possible sensor lock
up which can cause the wrong temperature value to be reported.
This fix leads to remove disabling thermal polling from
reset_asic_csrs() function.
Reviewed by: Dennis Dalessandro <dennis.dalessandro at intel.com>
Reviewed by: Easwar Hariharan <easwar.hariharan at intel.com>
Signed-off-by: Jareer Abdel-Qader <jareer.h.abdel-qader at intel.com>
Signed-off-by: Ira Weiny <ira.weiny at intel.com>
Signed-off-by: Jubin John <jubin.john at intel.com>
---
Changes in v2:
- Fixed author name format
drivers/staging/rdma/hfi1/chip.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rdma/hfi1/chip.c b/drivers/staging/rdma/hfi1/chip.c
index e489819..e1951f4 100644
--- a/drivers/staging/rdma/hfi1/chip.c
+++ b/drivers/staging/rdma/hfi1/chip.c
@@ -9455,7 +9455,7 @@ static void reset_asic_csrs(struct hfi1_devdata *dd)
/* We might want to retain this state across FLR if we ever use it */
write_csr(dd, ASIC_CFG_DRV_STR, 0);
- write_csr(dd, ASIC_CFG_THERM_POLL_EN, 0);
+ /* ASIC_CFG_THERM_POLL_EN leave alone */
/* ASIC_STS_THERM read-only */
/* ASIC_CFG_RESET leave alone */
@@ -10803,7 +10803,9 @@ static int thermal_init(struct hfi1_devdata *dd)
acquire_hw_mutex(dd);
dd_dev_info(dd, "Initializing thermal sensor\n");
-
+ /* Disable polling of thermal readings */
+ write_csr(dd, ASIC_CFG_THERM_POLL_EN, 0x0);
+ msleep(100);
/* Thermal Sensor Initialization */
/* Step 1: Reset the Thermal SBus Receiver */
ret = sbus_request_slow(dd, SBUS_THERMAL, 0x0,
--
1.7.1
More information about the devel
mailing list