[PATCH 15/22] staging: comedi: adv_pci1710: tidy up analog output subdev_flags

Ian Abbott abbotti at mev.co.uk
Thu Nov 5 13:00:50 UTC 2015


On 04/11/15 16:55, H Hartley Sweeten wrote:
> The SDF_GROUND and SDF_COMMON flags are not needed for the analog output
> subdevice. Just remove them.
>
> Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
> Cc: Ian Abbott <abbotti at mev.co.uk>
> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> ---
>   drivers/staging/comedi/drivers/adv_pci1710.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/adv_pci1710.c b/drivers/staging/comedi/drivers/adv_pci1710.c
> index 339130b..0511f26 100644
> --- a/drivers/staging/comedi/drivers/adv_pci1710.c
> +++ b/drivers/staging/comedi/drivers/adv_pci1710.c
> @@ -817,7 +817,7 @@ static int pci1710_auto_attach(struct comedi_device *dev,
>   	if (board->has_ao) {
>   		s = &dev->subdevices[subdev];
>   		s->type		= COMEDI_SUBD_AO;
> -		s->subdev_flags	= SDF_WRITABLE | SDF_GROUND | SDF_COMMON;
> +		s->subdev_flags	= SDF_WRITABLE;
>   		s->n_chan	= 2;
>   		s->maxdata	= 0x0fff;
>   		s->range_table	= &pci171x_ao_range;
>

The signal connector has separate pins for AIGND, AOGND and DGND, 
although ultimately they are referenced to the same voltage.  I'd just 
leave the SDF_GROUND and SDF_COMMON flags set, same as for the analog 
input subdevice.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-


More information about the devel mailing list