[PATCH] staging/rdma/hfi1: set Gen3 half-swing for integrated devices

Dan Carpenter dan.carpenter at oracle.com
Thu Nov 5 07:34:48 UTC 2015


On Wed, Nov 04, 2015 at 09:06:08PM -0500, ira.weiny at intel.com wrote:

> +#define CCE_PCIE_CTRL_XMT_MARGIN_GEN1_GEN2_OVERWRITE_ENABLE_MASK 0x1ull

There is absolutely no point to having a variable name which is nine
bajillion characters long since we are not able to use it and have to
instead use macro majic to hide the first twelve zillion characters.  If
we can't even see the name when it is used, then why does it exist? Also
macro magic breaks grep and cscope.  Just think of a better name to
begin with and get rid of the PC macro.

regards,
dan carpenter



More information about the devel mailing list