[PATCH 01/11] staging: rtl8188eu: new temporary variable added to _rtl88e_fill_dummy

Dan Carpenter dan.carpenter at oracle.com
Wed Nov 4 11:07:37 UTC 2015


On Wed, Nov 04, 2015 at 10:11:19AM +0700, Ivan Safonov wrote:
> It makes easier to understand the transition to a simpler function form.
> 

You're really breaking your patches into to small pieces.  This patch
makes no sense on its own and introduces a static checker warning that
n is assigned but never used.

> Signed-off-by: Ivan Safonov <insafonov at gmail.com>
> ---
>  drivers/staging/rtl8188eu/hal/fw.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188eu/hal/fw.c
> index 23aa6d3..d502606 100644
> --- a/drivers/staging/rtl8188eu/hal/fw.c
> +++ b/drivers/staging/rtl8188eu/hal/fw.c
> @@ -83,10 +83,11 @@ static void _rtl88e_fw_block_write(struct adapter *adapt,
>  
>  static void _rtl88e_fill_dummy(u8 *pfwbuf, u32 *pfwlen)
>  {
> -	u32 fwlen = *pfwlen;
> +	u32 fwlen = *pfwlen, n;

Put these on separate lines.  Generally, it's one variable per line but
especially in this case where we have an initialization.

regards,
dan carpenter



More information about the devel mailing list