[PATCH] staging: fbtft: replace fbtft_dev_dbg with standard dev_dbg call

Greg Kroah-Hartman gregkh at linuxfoundation.org
Sun May 31 02:51:45 UTC 2015


On Sun, May 31, 2015 at 08:02:22AM +0530, c.r.madhusudhanan at gmail.com wrote:
> 
> On 31-May-2015 06:59, "Greg Kroah-Hartman" <gregkh at linuxfoundation.org> wrote:
> >
> > On Tue, May 12, 2015 at 03:15:21PM +0000, Ravindran, Madhusudhanan (M.)
> wrote:
> > > This patch attempts to simplify the debugging using standard
> > > dev_dbg call so that individual debug prints can be enabled or
> > > disbled by dynamic debugging rather than using module params.
> > >
> > > Signed-off-by: Madhusudhanan Ravindran <mravindr at visteon.com>
> >
> > Name doesn't match the From: line :(
> >
> Greg, thank for your time reviewing it.
> 
> I find Outlook posts in Lastname Firstname format and ignores whatever I
> configure in mutt/git. I think I can't change it as it falls in the global IT
> configuration.. but I will speak to them and try again.

Ok, if that's a problem then use the extra "From:" line in the patch
itself as the first line of the changelog entry.  That way git will do
the right thing and use that instead of the "broken" version.

I think the SubmittingPatches file describes this.

Oh, and congrats on getting Outlook to send patches, that's a hard thing
to do, I only know of one other company to succeed at that, and it
wasn't even Microsoft :)

thanks,

greg k-h


More information about the devel mailing list