[PATCH] staging: gs_fpgaboot: remove redundant code

Dan Carpenter dan.carpenter at oracle.com
Thu May 28 10:38:49 UTC 2015


On Thu, May 28, 2015 at 10:19:40AM +0000, Gujulan Elango, Hari Prasath (H.) wrote:
> > >  	fimage = kmalloc(sizeof(struct fpgaimage), GFP_KERNEL);
> > >  	if (!fimage)
> > > @@ -298,44 +299,41 @@ static int gs_fpgaboot(void)
> > >  	err = gs_load_image(fimage, file);
> > >  	if (err) {
> > 
> > 		goto free_fimage;
> > 
> 
> I guess we should retain the debug message here and in the other cases
> below.

Just delete the debug messages.  It's fine.  Please send a v2.

If you want to rename "err" to "ret" that's also ok, or you can leave it
as is.  But don't introduce a new variable.

regards,
dan carpenter



More information about the devel mailing list