[PATCHv2 06/16] vme: check for A64 overflow in vme_check_window()

Dmitry Kalinkin dmitry.kalinkin at gmail.com
Thu May 28 09:31:12 UTC 2015


Signed-off-by: Dmitry Kalinkin <dmitry.kalinkin at gmail.com>
Cc: Igor Alekseev <igor.alekseev at itep.ru>
---
 drivers/vme/vme.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/vme/vme.c b/drivers/vme/vme.c
index 6bab2c4..1b78d27 100644
--- a/drivers/vme/vme.c
+++ b/drivers/vme/vme.c
@@ -199,10 +199,8 @@ static int vme_check_window(u32 aspace, unsigned long long vme_base,
 			retval = -EFAULT;
 		break;
 	case VME_A64:
-		/*
-		 * Any value held in an unsigned long long can be used as the
-		 * base
-		 */
+		if ((size != 0) && (vme_base > U64_MAX + 1 - size))
+			retval = -EFAULT;
 		break;
 	case VME_CRCSR:
 		if (((vme_base + size) > VME_CRCSR_MAX) ||
-- 
1.8.3.1



More information about the devel mailing list