[PATCH] staging: gdm72xx: remove unneeded test
Dan Carpenter
dan.carpenter at oracle.com
Thu May 28 07:14:44 UTC 2015
On Wed, May 27, 2015 at 01:30:08PM -0700, Joe Perches wrote:
> On Wed, 2015-05-27 at 22:25 +0200, Laurent Navet wrote:
> > The same code is executed regardless ret value, so this test can be
> > removed.
> []
> > diff --git a/drivers/staging/gdm72xx/usb_boot.c b/drivers/staging/gdm72xx/usb_boot.c
> []
> > @@ -255,8 +255,6 @@ static int em_wait_ack(struct usb_device *usbdev, int send_zlp)
> >
> > /*Wait for ACK*/
> > ret = gdm_wibro_recv(usbdev, &ack, sizeof(ack));
> > - if (ret < 0)
> > - goto out;
> > out:
> > return ret;
> > }
>
> Perhaps all of the uses like:
>
> goto <foo>;
> <foo>:
>
> could be modified. There are ~150 in the kernel.
Joe, these are a kind of style. You're just directing a newbie into a
hornets nest. Laurant, don't do listen to Joe unless you like getting
flamed.
regards,
dan carpenter
More information about the devel
mailing list