staging: unisys: Convert bus functions to pass bus_info pointer around

Dan Carpenter dan.carpenter at oracle.com
Wed May 27 16:11:30 UTC 2015


On Wed, May 27, 2015 at 07:02:51PM +0300, Dan Carpenter wrote:
> Hello Don Zickus,
> 
> This is a semi-automatic email about new static checker warnings.
> 
> The patch 3032aeddd85e: "staging: unisys: Convert bus functions to 
> pass bus_info pointer around" from May 13, 2015, leads to the 
> following Smatch complaint:
> 
> drivers/staging/unisys/visorbus/visorchipset.c:971 bus_responder()
> 	 warn: variable dereferenced before check 'p' (see line 969)
> 
> drivers/staging/unisys/visorbus/visorchipset.c
>    968		bool need_clear = false;
>    969		u32 bus_no = p->bus_no;
>                              ^^^^^^^^^
> Dereference.
> 
>    970	
>    971		if (!p)
>                     ^^^
> Check.
> 
>    972			return;
>    973	
> 

There is another one as well in device_changestate_responder()

	drivers/staging/unisys/visorbus/visorchipset.c:1007 device_changestate_responder()
	warn: variable dereferenced before check 'p' (see line 1004)

regards,
dan carpenter



More information about the devel mailing list