[PATCH] staging: sm750fb: replace kzalloc with devm_kzalloc

Sudip Mukherjee sudipm.mukherjee at gmail.com
Wed May 27 08:45:16 UTC 2015


On Wed, May 27, 2015 at 11:37:19AM +0300, Dan Carpenter wrote:
> On Wed, May 27, 2015 at 01:29:31PM +0530, Sudip Mukherjee wrote:
> > tested again.
> > strange behaviour.
> > if i send your patch to checkpatch from mutt via pipe I am getting these
> > errors but if i save your patch to a file and then apply checkpatch to
> > that file there is no error. This is the first time I am seeing this.
> > 
> > Dan, any idea why?
> 
> No idea.  I wanted to say that you were saving with mutt's <decode-copy>
> command but the email is in us-ascii so that theory doesn't work.
> 
> How are you piping it to checkpatch.pl?  I didn't know you could pipe to
> checkpatch.

press | , it will ask for "pipe to command:" there enter:
scripts/checkpatch.pl --strict -

this is the way I will check all patches, I will usually do | then
scripts/checkpatch.pl --strict - 
if this is ok then
git apply - && make M=drivers/staging

so this will apply the patch and build if git apply was successfull.

regards
sudip
> 
> regards,
> dan carpenter


More information about the devel mailing list