[PATCH] staging: sm750fb: Add missing Kconfig dependency

Gujulan Elango, Hari Prasath (H.) hgujulan at visteon.com
Wed May 27 06:18:02 UTC 2015


On Wed, May 27, 2015 at 11:32:11AM +0530, Sudip Mukherjee wrote:
> On Tue, May 26, 2015 at 02:50:30PM +0000, Gujulan Elango, Hari Prasath (H.) wrote:
> > The Kconfig dependency for this driver should include the kernel
> > configuration FB_MODE_HELPERS which defines the vesa_modes
> > structure.Without this dependency,the driver build generates a linker 
> > error if build as a built-in driver.
> 
> thanks, we all missed this. But while building it also showed:
> undefined reference to cfb_fillrect, cfb_copyarea, cfb_imageblit.
> And having a look at all the other framebuffer drivers the correct fix
> should be:
> 

I got only one build error which was undefined reference to
`vesa_modes'.How come I didn't get these other undefined references ?
May be I am missing something ?

> diff --git a/drivers/staging/sm750fb/Kconfig b/drivers/staging/sm750fb/Kconfig
> index c40d088..ccebc25 100644
> --- a/drivers/staging/sm750fb/Kconfig
> +++ b/drivers/staging/sm750fb/Kconfig
> @@ -1,6 +1,10 @@
>  config FB_SM750
>  	tristate "Silicon Motion SM750 framebuffer support"
>  	depends on FB && PCI
> +	select FB_MODE_HELPERS
> +	select FB_CFB_FILLRECT
> +	select FB_CFB_COPYAREA
> +	select FB_CFB_IMAGEBLIT
>  	help
>  	  Frame buffer driver for the Silicon Motion SM750 chip
>  	  with 2D accelearion and dual head support.
> 
> 
> > 
> > Signed-off-by: Hari Prasath Gujulan Elango <hgujulan at visteon.com>
> And your Signed-off-by and the email header From: name is not matching.
> please send a new patch with these changes.
> 
> regards
> sudip

I changed it in my local gitconfig file. From now on it should be
correct as you expect.I will send v2 patch after my confusion is
clarified.


More information about the devel mailing list