[PATCH] staging: sm750fb: Add missing Kconfig dependency

Sudip Mukherjee sudipm.mukherjee at gmail.com
Wed May 27 06:02:11 UTC 2015


On Tue, May 26, 2015 at 02:50:30PM +0000, Gujulan Elango, Hari Prasath (H.) wrote:
> The Kconfig dependency for this driver should include the kernel
> configuration FB_MODE_HELPERS which defines the vesa_modes
> structure.Without this dependency,the driver build generates a linker 
> error if build as a built-in driver.

thanks, we all missed this. But while building it also showed:
undefined reference to cfb_fillrect, cfb_copyarea, cfb_imageblit.
And having a look at all the other framebuffer drivers the correct fix
should be:

diff --git a/drivers/staging/sm750fb/Kconfig b/drivers/staging/sm750fb/Kconfig
index c40d088..ccebc25 100644
--- a/drivers/staging/sm750fb/Kconfig
+++ b/drivers/staging/sm750fb/Kconfig
@@ -1,6 +1,10 @@
 config FB_SM750
 	tristate "Silicon Motion SM750 framebuffer support"
 	depends on FB && PCI
+	select FB_MODE_HELPERS
+	select FB_CFB_FILLRECT
+	select FB_CFB_COPYAREA
+	select FB_CFB_IMAGEBLIT
 	help
 	  Frame buffer driver for the Silicon Motion SM750 chip
 	  with 2D accelearion and dual head support.


> 
> Signed-off-by: Hari Prasath Gujulan Elango <hgujulan at visteon.com>
And your Signed-off-by and the email header From: name is not matching.
please send a new patch with these changes.

regards
sudip


More information about the devel mailing list