[PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()
Larry Finger
Larry.Finger at lwfinger.net
Mon May 25 15:52:43 UTC 2015
On 05/25/2015 04:37 AM, Vaishali Thakkar wrote:
>
> On 25 May 2015 14:49, "Dan Carpenter" <dan.carpenter at oracle.com
> <mailto:dan.carpenter at oracle.com>> wrote:
> >
> > On Sun, May 24, 2015 at 07:11:40PM -0500, Larry Finger wrote:
> > > On 05/24/2015 02:03 PM, Haggai Eran wrote:
> > > >On 24 May 2015 at 00:16, Larry Finger <Larry.Finger at lwfinger.net
> <mailto:Larry.Finger at lwfinger.net>> wrote:
> > > >>The driver is reporting a warning at kernel/time/timer.c:1096 due to calling
> > > >>del_timer_sync() while in interrupt mode. Such warnings are fixed by calling
> > > >>del_timer() instead.
> > > >>
> > > >>Signed-off-by: Larry Finger <Larry.Finger at lwfinger.net
> <mailto:Larry.Finger at lwfinger.net>>
> > > >>Cc: Stable <stable at vger.kernel.org <mailto:stable at vger.kernel.org>>
> > > >>Cc: Haggi Eran <haggai.eran at gmail.com <mailto:haggai.eran at gmail.com>>
> > > >
> > > >Hi,
> > > >
> > > >I haven't been using kernel v4.1 so I haven't seen this warning, but looking
> > > >at the code it seems to originate from the two recent patches to remove
> > > >_cancel_timer and _cancel_timer_ex. I see that there's another patch in
> lkml [1]
> > > >that changes del_timer_sync back to del_timer in more places. Perhaps it
> > > >could prevent other warnings like this in the future.
> > > >
> > > >Regards,
> > > >Haggai
> > > >
> > > >[1] https://lkml.org/lkml/2015/5/15/226
> > >
> > > Yes, the script kiddies make changes they do not understand and
> > > screw everything up. Unfortunately, I did not catch these in review.
> > > I think I will submit V2 and blast the contributor.
> >
> > Don't blast the contributor... These are special intern patches that
> > dont' go through the normal review process. The intern process is over
> > this year. The lack of normal review introduced a number of bugs this
> > year. I always complain to Greg about it and he says that I should join
> > the intern mailing list if I care so much.
>
> I am sorry for those patches. It was me who introduced those bugs. Yes, it was
> sent during Outreachy process. But it was my mistake as a newbie. May be I
> should have taken care of interrupt mode thing.
>
> I would like to fix it if someone is not doing it. Sorry again. I will take care
> of these things in my future patches.
No, one of us will fix the problems with r8712u. The hardware is needed for
proper testing, and I doubt that you have it.
Larry
More information about the devel
mailing list