[PATCH 1/4] Staging: lustre: sparse static warning fix

Adrian Remonda adrianremonda at gmail.com
Mon May 18 18:34:48 UTC 2015


This patch clears the warning given by sparse that the function should be static.
Done by moving the declaration of the structure  'nrs_conf_fifo' into the header
'ptlrpc_internal.h'

	modified:   drivers/staging/lustre/lustre/ptlrpc/nrs.c
	modified:   drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h

Signed-off-by: Adrian Remonda <adrianremonda at gmail.com>
---
 drivers/staging/lustre/lustre/ptlrpc/nrs.c             | 4 ----
 drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h | 4 ++++
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/lustre/lustre/ptlrpc/nrs.c b/drivers/staging/lustre/lustre/ptlrpc/nrs.c
index 63a05f4a902d..159db41c53a0 100644
--- a/drivers/staging/lustre/lustre/ptlrpc/nrs.c
+++ b/drivers/staging/lustre/lustre/ptlrpc/nrs.c
@@ -1698,10 +1698,6 @@ out:
 	return rc;
 }
 
-
-/* ptlrpc/nrs_fifo.c */
-extern struct ptlrpc_nrs_pol_conf nrs_conf_fifo;
-
 /**
  * Adds all policies that ship with the ptlrpc module, to NRS core's list of
  * policies \e nrs_core.nrs_policies.
diff --git a/drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h b/drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h
index a66dc3c6da41..e07e2aacc62c 100644
--- a/drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h
+++ b/drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h
@@ -309,4 +309,8 @@ static inline void ptlrpc_reqset_put(struct ptlrpc_request_set *set)
 	if (atomic_dec_and_test(&set->set_refcount))
 		OBD_FREE_PTR(set);
 }
+
+/* ptlrpc/nrs_fifo.c */
+extern struct ptlrpc_nrs_pol_conf nrs_conf_fifo;
+
 #endif /* PTLRPC_INTERNAL_H */
-- 
2.1.4



More information about the devel mailing list