[PATCH v2] Staging: rtl8192u: Fix coding style issues at ieee80211_crypt_wep.c

Dan Carpenter dan.carpenter at oracle.com
Mon May 18 16:15:31 UTC 2015


On Mon, May 18, 2015 at 07:36:23PM +0200, Pedro Marzo Perez wrote:
> Merge two pr_debug lines with literal strings splitted across several lines
> into one single line, simplifying prism2_wep_init error check code.
> Openning braces should never be in a new line, move them to the end of
> the previous line.
> Removed two useless lines at ieee80211_wep_null.
> 

When Joe said "Some will say this is doing too many things in a single
patch." he meant Greg.  Break this up into multiple patches.  Especially
now that you've added even more stuff to it.

regards,
dan carpenter


More information about the devel mailing list