[PATCH] Clarify expression which uses both multiplication and pointer dereference

Alex Dowad alexinbeijing at gmail.com
Mon May 18 03:59:18 UTC 2015



On 17/05/15 22:16, Joe Perches wrote:
> On Sun, 2015-05-17 at 19:18 +0200, Alex Dowad wrote:
>> This fixes a checkpatch style error in vpfe_buffer_queue_setup.
> There is no checkpatch message for this style.
>
> Nor should there be.
Strange. With:

cd drivers/staging/media
../../../scripts/checkpatch.pl -f **/*.c

Among pages of output, I get:

------------------
ERROR: "foo * *bar" should be "foo **bar"
#1098: FILE: davinci_vpfe/vpfe_video.c:1098:
+               while (size * *nbuffers > vpfe_dev->video_limit)

total: 1 errors, 0 warnings, 1636 lines checked

davinci_vpfe/vpfe_video.c has style problems, please review.
------------------

But with:

cd drivers/staging/media/davinci_vpfe
../../../../scripts/checkpatch.pl -f vpfe_video.c

...Then checkpatch is happy!

I may try to investigate this further and see if there is some bug in 
checkpatch. Anyhow, sorry for the false alarm.

Thanks,
Alex Dowad


More information about the devel mailing list