[PATCH] staging: rts5208: remove variable and check directly

Gujulan Elango, Hari Prasath (H.) hgujulan at visteon.com
Fri May 15 11:33:53 UTC 2015


This trivial patch removes temporary variable to check return value of
a function and checks return value directly.

Signed-off-by: Hari Prasath Gujulan Elango <hgujulan at visteon.com>
---
 drivers/staging/rts5208/ms.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c
index ee818b0..ab6e8bc 100644
--- a/drivers/staging/rts5208/ms.c
+++ b/drivers/staging/rts5208/ms.c
@@ -52,7 +52,6 @@ static int ms_transfer_tpc(struct rtsx_chip *chip, u8 trans_mode,
 			u8 tpc, u8 cnt, u8 cfg)
 {
 	struct ms_info *ms_card = &(chip->ms_card);
-	int retval;
 	u8 *ptr;
 
 	dev_dbg(rtsx_dev(chip), "%s: tpc = 0x%x\n", __func__, tpc);
@@ -72,8 +71,7 @@ static int ms_transfer_tpc(struct rtsx_chip *chip, u8 trans_mode,
 
 	rtsx_add_cmd(chip, READ_REG_CMD, MS_TRANS_CFG, 0, 0);
 
-	retval = rtsx_send_cmd(chip, MS_CARD, 5000);
-	if (retval < 0) {
+	if (rtsx_send_cmd(chip, MS_CARD, 5000) < 0) {
 		rtsx_clear_ms_error(chip);
 		ms_set_err_code(chip, MS_TO_ERROR);
 		rtsx_trace(chip);
-- 
1.9.1


More information about the devel mailing list