[PATCH] staging: comedi: ni_mio_common: fix build warning

Ian Abbott abbotti at mev.co.uk
Mon May 11 19:03:41 UTC 2015


On 11/05/15 18:22, H Hartley Sweeten wrote:
> The kbuild test robot detected a build warning causes by commit f878071a.
>
>>> drivers/staging/comedi/drivers/ni_mio_common.c:2274:34:
>     warning: right-hand operand of comma expression has no effect [-Wunused-value]
>
> That line should have been terminated by ';' and the following line removed.
> Not sure why it even builds on my test system...
>
> Reported-by: kbuild test robot
> Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
> Cc: Ian Abbott <abbotti at mev.co,uk>

Minor niggle: that email address is malformed (comma instead of dot).

> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> ---
>   drivers/staging/comedi/drivers/ni_mio_common.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c
> index c741dde..9dfd4e6 100644
> --- a/drivers/staging/comedi/drivers/ni_mio_common.c
> +++ b/drivers/staging/comedi/drivers/ni_mio_common.c
> @@ -2268,8 +2268,7 @@ static int ni_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
>   	case TRIG_INT:
>   	case TRIG_NOW:
>   		ai_trig |= NISTC_AI_TRIG_START1_EDGE |
> -			   NISTC_AI_TRIG_START1_SEL(0),
> -			   NISTC_AI_TRIG_SEL_REG;
> +			   NISTC_AI_TRIG_START1_SEL(0);
>   		break;
>   	case TRIG_EXT:
>   		ai_trig |= NISTC_AI_TRIG_START1_SEL(CR_CHAN(cmd->start_arg) +
>

Reviewed-by: Ian Abbott <abbotti at mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-


More information about the devel mailing list