[PATCH 125/141] staging: unisys: Convert cmd functions to visor_device

Dan Carpenter dan.carpenter at oracle.com
Sat May 9 09:06:32 UTC 2015


On Sat, May 09, 2015 at 12:05:19PM +0300, Dan Carpenter wrote:
> On Sat, May 09, 2015 at 12:01:54PM +0300, Dan Carpenter wrote:
> > On Tue, May 05, 2015 at 06:37:42PM -0400, Benjamin Romer wrote:
> > > From: Don Zickus <dzickus at redhat.com>
> > >  
> > >  cleanup:
> > > -	bus_epilog(bus_no, CONTROLVM_BUS_CREATE, &inmsg->hdr,
> > > +	bus_epilog(bus_info, CONTROLVM_BUS_CREATE, &inmsg->hdr,
> > >  		   rc, inmsg->hdr.flags.response_expected == 1);
> > >  }
> > 
> > On some error paths "bus_info" is NULL.  One err bug.
> 
> Ugh...  Basically ever place that calls bus_epilog() is buggy.

Or device_epilog().

regards,
dan carpenter



More information about the devel mailing list