[PATCH 000/141] staging: unisys: s-Par driver rebuild series
Ben Romer
benjamin.romer at unisys.com
Fri May 8 13:32:04 UTC 2015
On 05/08/2015 04:52 AM, Dan Carpenter wrote:
> I'm finished going through these patches. Pretty decent over all.
>
> My only comment was that there were three? places where we introduced a
> bug and then fixed it in a later patch. I kind of wish the fix were
> folded into the original patch. I don't know how awkward that is. If
> it's too difficult then don't worry about it.
It seems that Greg is merging most (if not all) of the patchset into
staging-testing now, so it'd be more trouble to generate a v2 than it's
worth, but we are going to make sure we take care of all of the flaws
you've pointed out. :)
> I also missed all three of those bugs so my review obviously wasn't
> perfect. :P
The feedback was very valuable to us! :) Thanks for taking the time to
go over everything. I'm hoping that we'll have patches sent in by next
week, for each of the mistakes of ours that you found. :)
Thanks again! :)
-- Ben
More information about the devel
mailing list