[PATCH] staging: comedi: coding style identation error fix

Jaime Arrocha jarrocha at kerneldev.net
Thu May 7 14:36:52 UTC 2015



On 05/07/2015 08:21 AM, Sudip Mukherjee wrote:
> On Thu, May 07, 2015 at 08:01:53AM -0500, Jaime Arrocha wrote:
>>
>>
>> On 05/07/2015 12:34 AM, Sudip Mukherjee wrote:
>>> On Wed, May 06, 2015 at 05:13:41PM -0500, Jaime Arrocha wrote:
>>>> Errors found by checkpatch.pl.
>>>> ERROR: code indent should use tabs where possible
>>>> /drivers/staging/comedi/drivers/das16m1.c:49
>>>> /drivers/staging/comedi/drivers/das16m1.c:50
>>>>
>>>> Signed-off-by: Jaime Arrocha <jarr at kerneldev.net>
>>>> ---
>>> you are sending this patch second time with different subject.
>>> any reason for that?
>>>
>>> regards
>>> sudip
>>>
>>
>> Yes, the first one had the subject line too long and not clear.
>> When I need to resend a patch like I did, should I add on the second
>> one the reason behind resending and dismissing the first one? Thank
>> you.
>
> first of all you should reply to the first patch stating that should not
> be applied and that you have sent a second patch. And this one should
> have had a v2 in the subject with the reason of v2 below the --- cutoff.
> since you have already sent the second patch just reply to the fist
> patch as of now.
> And you have sent the patches to greg at kroah.com, it should have been
> gregkh at linuxfoundation.org . always use get_maintainer.pl to see whom
> to send patches.
>
> regards
> sudip
>
>

Thanks Sudip, I will dismiss this one too and do it correctly. I 
accidentally took Greg's email from the TODO file.




This patch should not be applied.



Thanks,
jaime



More information about the devel mailing list