[HPDD-discuss] [PATCH] Staging: lustre: file.c: fix coding style

Julia Lawall julia.lawall at lip6.fr
Wed Mar 18 22:46:07 UTC 2015


On Wed, 18 Mar 2015, Patrick Farrell wrote:

> Uck, my reply made the formatting even worse.  I'm trying to say it should
> look like this:
> +            rc = ll_intent_file_open(file->f_path.dentry,
> +                                                    NULL, 0, it);
> Not like this:
> +            rc = ll_intent_file_open(file->f_path.dentry,
> +                                                   NULL, 0, it);

Both look wrong to me.  Are your tabs equivalent to 8 spaces?

julia

> 
> On 03/18/2015 02:31 PM, Patrick Farrell wrote:
> > Perhaps this is just a formatting error in my email client, but shouldn't
> > NULL be one more space over to line up with the '(' above?
> > 
> > On 03/18/2015 02:08 PM, py at amd48-systeme.lip6.fr wrote:
> > > +            rc = ll_intent_file_open(file->f_path.dentry,
> > > +                        NULL, 0, it);
> > 
> > _______________________________________________
> > HPDD-discuss mailing list
> > HPDD-discuss at lists.01.org
> > https://lists.01.org/mailman/listinfo/hpdd-discuss
> 
> 


More information about the devel mailing list