[PATCH] Staging: dgnc: release the lock before testing for nullity

Quentin Lambert lambert.quentin at gmail.com
Wed Mar 18 12:51:52 UTC 2015


Fixes: c84a083b995b ("Staging: dgnc: Use goto for spinlock release before return")

Signed-off-by: Quentin Lambert <lambert.quentin at gmail.com>
---
 drivers/staging/dgnc/dgnc_tty.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index 8445f84ddaa3..f1c4d07a0aaa 100644
--- a/drivers/staging/dgnc/dgnc_tty.c
+++ b/drivers/staging/dgnc/dgnc_tty.c
@@ -656,9 +656,9 @@ void dgnc_input(struct channel_t *ch)
 	return;
 
 exit_unlock:
+	spin_unlock_irqrestore(&ch->ch_lock, flags);
 	if (ld)
 		tty_ldisc_deref(ld);
-	spin_unlock_irqrestore(&ch->ch_lock, flags);
 }
 
 
-- 
2.3.2.223.g7a9409c



More information about the devel mailing list