[PATCH v2] staging: panel: change struct bits to a bit array

Sudip Mukherjee sudipm.mukherjee at gmail.com
Sat Mar 14 08:32:31 UTC 2015


On Sat, Mar 14, 2015 at 12:20:36AM +0100, Isaac Lleida wrote:
> This path implements a bit array representing the LCD signal states instead of the old "struct bits", which used char to represent a single bit. This will reduce the memory usage.

commit log should wrap at 72 char

> 
> Signed-off-by: Isaac Lleida <illeida at openaliasbox.org

missing '>'

> ---
> v2: fix some stupid errors from the first patch
> 
<snip>
> +#define BIT_ON(b, m)	(b |= m)
> +#define BIT_OFF(b, m)	(b &= ~m)
> +#define BIT_CHK(b, m)	(b & m)
> +#define BIT_MOD(b, m, v)				\
> +	(((v) ? BIT_ON(b, m) : BIT_OFF(b, m))?1:0)	\
missing ' ' around ? and :

please test your patch by checkpatch.pl before sending

regards
sudip


More information about the devel mailing list