[PATCH] staging: fbtft: Use kmemdup rather than duplicating its implementation

Abdul Hussain S hussain.abdul at outlook.com
Fri Mar 13 10:31:32 UTC 2015


The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci

Change-Id: I3ae055f5efe63acc3a71e52c1eb677ebd16e538b
Signed-off-by: Abdul Hussain S <hussain.abdul at outlook.com>
---
 drivers/staging/fbtft/fbtft-sysfs.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/fbtft/fbtft-sysfs.c b/drivers/staging/fbtft/fbtft-sysfs.c
index 45f8de3..ba4551f 100644
--- a/drivers/staging/fbtft/fbtft-sysfs.c
+++ b/drivers/staging/fbtft/fbtft-sysfs.c
@@ -37,10 +37,9 @@ int fbtft_gamma_parse_str(struct fbtft_par *par, unsigned long *curves,
 
 	fbtft_par_dbg(DEBUG_SYSFS, par, "%s\n", str);
 
-	tmp = kmalloc(size+1, GFP_KERNEL);
+	tmp = kmemdup(str, size + 1, GFP_KERNEL);
 	if (!tmp)
 		return -ENOMEM;
-	memcpy(tmp, str, size+1);
 
 	/* replace optional separators */
 	str_p = tmp;
-- 
1.7.9.5



More information about the devel mailing list