[PATCH 3/4] staging: sm750fb: correctly define SM750LE_REVISION_ID

Sudip Mukherjee sudipm.mukherjee at gmail.com
Sun Mar 8 17:31:47 UTC 2015


On Sun, Mar 08, 2015 at 02:59:03PM +0200, Giedrius Statkevičius wrote:
> On 2015.03.08 14:31, Sudip Mukherjee wrote:
> > -#define SM750LE_REVISION_ID (char)0xfe
> > +#ifndef SM750LE_REVISION_ID
> > +#define SM750LE_REVISION_ID ((unsigned char)0xfe)
> > +#endif
> 
> Do you need these parantheses? Also, you can now then fix up this line
> too to avoid a redundant cast in the same patch:
> sm750_hw.c: if(share->revid == (unsigned char)SM750LE_REVISION_ID){
good idea, thanks.
that extra parentheses is for checkpatch warning of complex macro value.

i will better send a v2 of the whole series after checking that resource_size_t.

regards
sudip
> 
> 
> -- 
> Thanks,
> Giedrius


More information about the devel mailing list