[PATCHv2 0/3] Lustre: get rid of deprecated cpumask calls

Greg Kroah-Hartman gregkh at linuxfoundation.org
Sat Mar 7 00:06:20 UTC 2015


On Wed, Mar 04, 2015 at 01:07:50AM -0500, green at linuxhacker.ru wrote:
> From: Oleg Drokin <green at linuxhacker.ru>
> 
> A recent crash report with CONFIG_CPUMASK_OFFSTACK enabled
> set off a chain of emails through which I learned that cpus_* functions
> are deprecated and should not be really used to operate on cpumasks.
> 
> These three patches do just that, replacing cpus_* and cpu_* calls
> with cpumask_ equivalents, getting rid of a sizable number or
> NR_CPUS references
> 
> Patch #1 is the most important because it fixes a very real crash on
> lustre module load.
> 
> ptlrpcd.c stll has a bit of NUMA binding problem (not leading to
> crashes as far as I know) that remains unfixed, while we are
> thinking how to better refactor this bit of code.
> There'll be a separate patch for that later.
> 
> please consider.
> 
> Oleg Drokin (3):
>   staging/lustre/ptlrpc: Do not use deprecated cpus_* functions
>   staging/lustre/libcfs: replace deprecated cpus_ calls with cpumask_
>   staging/lustre/o2iblnd: Don't use cpus_weight
> 
>  .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c    |   4 +-
>  .../staging/lustre/lustre/libcfs/linux/linux-cpu.c | 102 +++++++++++----------
>  drivers/staging/lustre/lustre/ptlrpc/ptlrpcd.c     |   8 +-
>  drivers/staging/lustre/lustre/ptlrpc/service.c     |   9 +-
>  4 files changed, 62 insertions(+), 61 deletions(-)

I applied the first series here, sorry.  You didn't say what was
different between this and the first one, so I'm assuming nothing.

Please be specific in the future...

thanks,

greg k-h


More information about the devel mailing list