[PATCH 2/2] Staging: fbtft: fb_pcd8544: Fixed coding style errors and warnings

Cláudio Maia crrm at isep.ipp.pt
Tue Mar 3 12:54:39 UTC 2015


This patch corrects the comments' style.

Signed-off-by: Cláudio Maia <crrm at isep.ipp.pt>
---
 drivers/staging/fbtft/fb_pcd8544.c |  107 +++++++++++++++++++-----------------
 1 file changed, 58 insertions(+), 49 deletions(-)

diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd8544.c
index a912c1a..fddb9cd 100644
--- a/drivers/staging/fbtft/fb_pcd8544.c
+++ b/drivers/staging/fbtft/fb_pcd8544.c
@@ -51,45 +51,50 @@ static int init_display(struct fbtft_par *par)
 
 	par->fbtftops.reset(par);
 
-	/* Function set */
-	write_reg(par, 0x21); /*
-			5:1  1
-			2:0  PD - Powerdown control: chip is active
-			1:0  V  - Entry mode: horizontal addressing
-			0:1  H  - Extended instruction set control: extended
-			*/
-
-	/* H=1 Temperature control */
-	write_reg(par, 0x04 | (tc & 0x3)); /*
-				2:1  1
-				1:x  TC1 - Temperature Coefficient: 0x10
-				0:x  TC0
-				*/
-
-	/* H=1 Bias system */
-	write_reg(par, 0x10 | (bs & 0x7)); /*
-				4:1  1
-				3:0  0
-				2:x  BS2 - Bias System
-				1:x  BS1
-				0:x  BS0
-				*/
-
-	/* Function set */
-	write_reg(par, 0x22);/*
-			5:1  1
-			2:0  PD - Powerdown control: chip is active
-			1:1  V  - Entry mode: vertical addressing
-			0:0  H  - Extended instruction set control: basic
-			*/
-
-	/* H=0 Display control */
-	write_reg(par, 0x08 | 4); /*
-				3:1  1
-				2:1  D  - DE: 10=normal mode
-				1:0  0
-				0:0  E
-				*/
+	/* Function set
+	 *
+	 * 5:1  1
+	 * 2:0  PD - Powerdown control: chip is active
+	 * 1:0  V  - Entry mode: horizontal addressing
+	 * 0:1  H  - Extended instruction set control: extended
+	 */
+	write_reg(par, 0x21);
+
+	/* H=1 Temperature control
+	 *
+	 * 2:1  1
+	 * 1:x  TC1 - Temperature Coefficient: 0x10
+	 * 0:x  TC0
+	 */
+	write_reg(par, 0x04 | (tc & 0x3));
+
+	/* H=1 Bias system
+	 *
+	 * 4:1  1
+	 * 3:0  0
+	 * 2:x  BS2 - Bias System
+	 * 1:x  BS1
+	 * 0:x  BS0
+	 */
+	write_reg(par, 0x10 | (bs & 0x7));
+
+	/* Function set
+	 *
+	 * 5:1  1
+	 * 2:0  PD - Powerdown control: chip is active
+	 * 1:1  V  - Entry mode: vertical addressing
+	 * 0:0  H  - Extended instruction set control: basic
+	 */
+	write_reg(par, 0x22);
+
+	/* H=0 Display control
+	 *
+	 * 3:1  1
+	 * 2:1  D  - DE: 10=normal mode
+	 * 1:0  0
+	 * 0:0  E
+	 */
+	write_reg(par, 0x08 | 4);
 
 	return 0;
 }
@@ -99,16 +104,20 @@ static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye)
 	fbtft_par_dbg(DEBUG_SET_ADDR_WIN, par, "%s(xs=%d, ys=%d, xe=%d, ye=%d)\n",
 			__func__, xs, ys, xe, ye);
 
-	/* H=0 Set X address of RAM */
-	write_reg(par, 0x80); /*7:1  1
-				6-0: X[6:0] - 0x00
-				*/
-
-	/* H=0 Set Y address of RAM */
-	write_reg(par, 0x40); /*7:0  0
-				6:1  1
-				2-0: Y[2:0] - 0x0
-				*/
+	/* H=0 Set X address of RAM
+	 *
+	 * 7:1  1
+	 * 6-0: X[6:0] - 0x00
+	 */
+	write_reg(par, 0x80);
+
+	/* H=0 Set Y address of RAM
+	 *
+	 * 7:0  0
+	 * 6:1  1
+	 * 2-0: Y[2:0] - 0x0
+	 */
+	write_reg(par, 0x40);
 }
 
 static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
-- 
1.7.9.5



More information about the devel mailing list