[PATCH 1/1] staging/comedi: remove unnecessary check around pci_dev_put

Maninder Singh maninder1.s at samsung.com
Thu Jun 25 10:50:26 UTC 2015


pci_dev_put cehcks for NULL pointer itself,
reported by coccinelle

Signed-off-by: Maninder Singh <maninder1.s at samsung.com>
Reviewed-by: Yogesh Gaur <yn.gaur at samsung.com>
---
 drivers/staging/comedi/drivers/adl_pci9118.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c b/drivers/staging/comedi/drivers/adl_pci9118.c
index fb3043d..19b5806 100644
--- a/drivers/staging/comedi/drivers/adl_pci9118.c
+++ b/drivers/staging/comedi/drivers/adl_pci9118.c
@@ -1717,8 +1717,7 @@ static void pci9118_detach(struct comedi_device *dev)
 		pci9118_reset(dev);
 	comedi_pci_detach(dev);
 	pci9118_free_dma(dev);
-	if (pcidev)
-		pci_dev_put(pcidev);
+	pci_dev_put(pcidev);
 }
 
 static struct comedi_driver adl_pci9118_driver = {
-- 
1.7.9.5



More information about the devel mailing list