[RFC][PATCH 1/1] staging:vt6655: Remove checks around dev_kfree_skb

Maninder Singh maninder1.s at samsung.com
Wed Jun 24 06:13:16 UTC 2015


dev_kfree_skb checks for NULL pointer itself.

Signed-off-by: Maninder Singh <maninder1.s at samsung.com>
Reviewed-by: Akhilesh Kumar <akhilesh.k at samsung.com>
---
 drivers/staging/vt6655/device_main.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index ca578d6..0c4b0de 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -767,8 +767,7 @@ static void device_free_td0_ring(struct vnt_private *pDevice)
 			dma_unmap_single(&pDevice->pcid->dev, pTDInfo->skb_dma,
 					 pTDInfo->skb->len, DMA_TO_DEVICE);
 
-		if (pTDInfo->skb)
-			dev_kfree_skb(pTDInfo->skb);
+		dev_kfree_skb(pTDInfo->skb);
 
 		kfree(pDesc->pTDInfo);
 	}
@@ -786,8 +785,7 @@ static void device_free_td1_ring(struct vnt_private *pDevice)
 			dma_unmap_single(&pDevice->pcid->dev, pTDInfo->skb_dma,
 					 pTDInfo->skb->len, DMA_TO_DEVICE);
 
-		if (pTDInfo->skb)
-			dev_kfree_skb(pTDInfo->skb);
+		dev_kfree_skb(pTDInfo->skb);
 
 		kfree(pDesc->pTDInfo);
 	}
-- 
1.7.9.5



More information about the devel mailing list