[PATCH] staging: speakup: replace simple_strtoul() with kstrtoint()

Sudip Mukherjee sudipm.mukherjee at gmail.com
Wed Jun 24 05:23:30 UTC 2015


On Wed, Jun 24, 2015 at 12:15:52AM +0100, Luis de Bethencourt wrote:
> On Wed, Jun 24, 2015 at 01:53:33AM +0300, Dan Carpenter wrote:
> > Nope.  Your patch is totally wrong (buggy).  Please be more careful in
> > the future.
> > 
> > regards,
> > dan carpenter
> > 
> 
> I saw other commits replace the obsolete simple_strtoul() this way and the
> documentation makes it look like it is a 1 to 1 replacement.
> 
> Sorry about this. I will investigate further to understand why this is buggy
> and be more careful in the future.
simple_strtoul returns unsigned long and kstrtoint gives int.
documentation says to use kstrtoul.

regards
sudip


More information about the devel mailing list