[PATCH] staging: comedi: fix sparse warning in ni_mio_common.c

Geliang Tang geliangtang at 163.com
Sat Jun 20 16:47:33 UTC 2015


This patch fixes the following sparse warning:

drivers/staging/comedi/drivers/ni_mio_common.c:573:26: warning: shift
too big (4294967295) for type int

Signed-off-by: Geliang Tang <geliangtang at 163.com>
---
 drivers/staging/comedi/drivers/ni_mio_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c
index 6cc304a..420f752 100644
--- a/drivers/staging/comedi/drivers/ni_mio_common.c
+++ b/drivers/staging/comedi/drivers/ni_mio_common.c
@@ -570,7 +570,7 @@ static inline void ni_set_bitfield(struct comedi_device *dev, int reg,
 static inline unsigned ni_stc_dma_channel_select_bitfield(unsigned channel)
 {
 	if (channel < 4)
-		return 1 << channel;
+		return 1 << (channel & 0x03);
 	if (channel == 4)
 		return 0x3;
 	if (channel == 5)
-- 
1.9.1




More information about the devel mailing list