[PATCH] staging: comedi: replace ENOSYS by proper error codes

One Thousand Gnomes gnomes at lxorguk.ukuu.org.uk
Fri Jun 12 21:06:16 UTC 2015


On Fri, 12 Jun 2015 13:43:27 -0700
Greg KH <gregkh at linuxfoundation.org> wrote:

> On Fri, Jun 12, 2015 at 10:20:38PM +0200, julien.dehee at gmail.com wrote:
> > From: Julien Dehee <julien.dehee at gmail.com>
> > 
> > comedi/comedi_fops.c
> >     use ENODEV following open manual

That should probably be ENXIO by a strict reading, but Linux has always
used ENODEV 8)

> > 
> > comedi/drivers.c
> >     use ENOTTY following ioctl manual
> > 
> > drivers/serial2002.c
> >     use ENOTTY following ioctl manual
> 
> What do you mean by "ioctl manual"?

man 2 ioctl

Unknown ioctls on a device should error with ENOTTY. It's one of
those crazy pieces of Unix history.



More information about the devel mailing list