[PATCHv2] staging:rtl8712:Fix compressed return statement

Larry Finger Larry.Finger at lwfinger.net
Fri Jun 5 17:42:07 UTC 2015


On 06/03/2015 11:48 PM, Mutharaju, Prasanna (P.) wrote:
> From: Prasanna Karthik <mkarthi3 at visteon.com>
>
> Fix reported by coccinelle compressing last two lines with single return
> call
>
> Signed-off-by: Prasanna Karthik <mkarthi3 at visteon.com>
>
> ---
> V2: Removed psta structure pointer which is not needed shown by compiler
>      Warning
> ---
> ---
>   drivers/staging/rtl8712/rtl871x_sta_mgt.c |    4 +---
>   1 files changed, 1 insertions(+), 3 deletions(-)

Much better.

Acked-by: Larry Finger <Larry.Finger at lwfinger.net>


>
> diff --git a/drivers/staging/rtl8712/rtl871x_sta_mgt.c b/drivers/staging/rtl8712/rtl871x_sta_mgt.c
> index a9b93d0..6ae8cdc 100644
> --- a/drivers/staging/rtl8712/rtl871x_sta_mgt.c
> +++ b/drivers/staging/rtl8712/rtl871x_sta_mgt.c
> @@ -270,12 +270,10 @@ void r8712_init_bcmc_stainfo(struct _adapter *padapter)
>
>   struct sta_info *r8712_get_bcmc_stainfo(struct _adapter *padapter)
>   {
> -	struct sta_info *psta;
>   	struct sta_priv *pstapriv = &padapter->stapriv;
>   	u8 bc_addr[ETH_ALEN] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};
>
> -	psta = r8712_get_stainfo(pstapriv, bc_addr);
> -	return psta;
> +	return r8712_get_stainfo(pstapriv, bc_addr);
>   }
>
>
>



More information about the devel mailing list