[PATCH v3 6/7] staging:lustre: style cleanups for lib-socket.c

Joe Perches joe at perches.com
Wed Jun 3 14:42:54 UTC 2015


On Wed, 2015-06-03 at 10:32 -0400, James Simmons wrote:
> Handle all the style issues reported by checkpatch.pl.
> Remove general white spaces, spaces in function calls,
> etc.
[]
> @@ -167,13 +164,14 @@ lnet_ipif_enumerate (char ***namesp)
>  		if (nalloc * sizeof(*ifr) > PAGE_CACHE_SIZE) {
>  			toobig = 1;
>  			nalloc = PAGE_CACHE_SIZE/sizeof(*ifr);
> -			CWARN("Too many interfaces: only enumerating first %d\n",
> -			      nalloc);
> +			CWARN("Too many interfaces: only enumerating "
> +			      "first %d\n", nalloc);

Please don't split single strings into multiple parts.

For a patch like this it'd be nice to specify that both
"git diff -w" and scripts/objdiff shows no differences.

Unless it does...



More information about the devel mailing list