[RFC PATCH] staging: rtl8192e: Rework EEPROM handling code

Mateusz Kulikowski mateusz.kulikowski at gmail.com
Thu Jul 30 14:42:15 UTC 2015


On Thu, Jul 30, 2015 at 07:40:14AM -0700, Greg KH wrote:
> On Thu, Jul 30, 2015 at 11:41:46AM +0300, Dan Carpenter wrote:
> > On Thu, Jul 30, 2015 at 10:31:04AM +0200, Mateusz Kulikowski wrote:
> > > As for other comments - could you take look at "Notes" from patch?
> > > This was one of main concerns for me - Wouldn't it be better 
> > > if I rewrite that code to use GPIO/SPI/EEPROM subsystems?
> > 
> > I don't know.  Let's just merge this as a clean up since you've already
> > done it and not do the other unless you really feel like it or the
> > linux-wireless people ask for it.
> 
> That would require it to be resent, I don't apply "RFC" patches :)

It will be resent soon - function names proposed by Dan are better.

Regards,
Mateusz


More information about the devel mailing list