[PATCH 2/4] Staging: most: fix snprintf() is printing too much

Christian Gromm christian.gromm at microchip.com
Thu Jul 30 07:05:39 UTC 2015


On Wed, 29 Jul 2015 11:53:34 +0530
Sudip Mukherjee <sudipm.mukherjee at gmail.com> wrote:

> On Tue, Jul 28, 2015 at 05:16:09PM +0200, Christian Gromm wrote:
> > This patch prevents snprintf from exceeding a given buffer size.
> > 
> > Reported-by: Dan Carpenter <dan.carpenter at oracle.com>
> > Signed-off-by: Christian Gromm <christian.gromm at microchip.com>
> > ---
> <snip>
> > -		snprintf(devnod_buf, PAGE_SIZE, "%s-%s", mdev, mdev_ch);
> > +		snprintf(devnod_buf, sizeof(devnod_buf), "%s-%s", mdev, mdev_ch);
> And this gives checkpatch warning for more than 80 char.

I know, but decided to keep it anyway for the sake of readabilty.
Thanks for pointing this out.

Regards
Chris

> 
> regards
> sudip



More information about the devel mailing list