[PATCH 3/3] staging: most: core.c: move static static specifier into MOST_CHNL_ATTR

Chaehyun Lim chaehyun.lim at gmail.com
Mon Jul 27 01:31:10 UTC 2015


Move static specifier into MOST_CHNL_ATTR to fix checkpatch error.
ERROR: Macros with complex values should be enclosed in parentheses

Signed-off-by: Chaehyun Lim <chaehyun.lim at gmail.com>
---
 drivers/staging/most/mostcore/core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/most/mostcore/core.c b/drivers/staging/most/mostcore/core.c
index 261cb62..2c998a2 100644
--- a/drivers/staging/most/mostcore/core.c
+++ b/drivers/staging/most/mostcore/core.c
@@ -111,7 +111,7 @@ struct most_c_attr {
 #define to_channel_attr(a) container_of(a, struct most_c_attr, attr)
 
 #define MOST_CHNL_ATTR(_name, _mode, _show, _store) \
-		struct most_c_attr most_chnl_attr_##_name = \
+		static struct most_c_attr most_chnl_attr_##_name = \
 		__ATTR(_name, _mode, _show, _store)
 
 /**
@@ -328,7 +328,7 @@ static ssize_t show_channel_starving(struct most_c_obj *c,
 
 
 #define create_show_channel_attribute(val) \
-	static MOST_CHNL_ATTR(val, S_IRUGO, show_##val, NULL)
+	MOST_CHNL_ATTR(val, S_IRUGO, show_##val, NULL)
 
 create_show_channel_attribute(available_directions);
 create_show_channel_attribute(available_datatypes);
@@ -477,7 +477,7 @@ static ssize_t store_set_packets_per_xact(struct most_c_obj *c,
 }
 
 #define create_channel_attribute(value) \
-	static MOST_CHNL_ATTR(value, S_IRUGO | S_IWUSR, \
+	MOST_CHNL_ATTR(value, S_IRUGO | S_IWUSR, \
 			      show_##value, \
 			      store_##value)
 
-- 
1.9.1



More information about the devel mailing list