[PATCH V2 0/6] iio: mxs-lradc: Clean up and add datasheet names

Marek Vasut marex at denx.de
Sun Jul 19 22:06:11 UTC 2015


On Sunday, July 19, 2015 at 10:49:47 PM, Dan Carpenter wrote:
> On Sun, Jul 19, 2015 at 11:33:43PM +0300, Dan Carpenter wrote:
> > I didn't necessarily read the thread that way, but the thread was
> > long...
> 
> I read the thread as saying that you sometimes get:
> 
> Reviewed-by: Some Person <email at bigcompany.com>

Hm, I'm trying to use this email as a single point-of-presence, but
maybe I should start separating reviews I do in my free time and
send my R-B and A-B from my private address ?

> With no other comments and what does that even mean because you don't
> know who that person is and if they are good at reviewing.  There isn't
> a solution to that.  But since we know Marek then that doesn't really
> apply here.  Also people were worried that companies were going to start
> counting Reviewed-by tags so we should discourage that.

Uh, OK, I wasn't aware of this.

> Anyway, I don't see Reviewed-by tags as a reward, only as added
> responsibility.

Yeah, that's a good point. If you review code and it turns out to be crap,
then the value of your R-B and A-B decreases.

Best regards,
Marek Vasut


More information about the devel mailing list