[PATCH] drivers: staging: rtl8192u: Fix "space required before the open parenthesis '('" errors

Greg Kroah-Hartman gregkh at linuxfoundation.org
Wed Jul 15 02:42:54 UTC 2015


On Sat, Jun 20, 2015 at 03:56:08PM -0500, Greg Donald wrote:
> Fix checkpatch.pl "space required before the open parenthesis '('" errors
> 
> Signed-off-by: Greg Donald <gdonald at gmail.com>
> ---
>  .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c    | 97 ++++++++++------------
>  1 file changed, 44 insertions(+), 53 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> index c2588f8..df20979 100644
> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> @@ -66,7 +66,7 @@ void HTUpdateDefaultSetting(struct ieee80211_device *ieee)
>  	pHTInfo->bRegBW40MHz = 1;
>  
>  	// CCK rate support in 40MHz channel
> -	if(pHTInfo->bRegBW40MHz)
> +	if (pHTInfo->bRegBW40MHz)
>  		pHTInfo->bRegSuppCCK = 1;
>  	else
>  		pHTInfo->bRegSuppCCK = true;
> @@ -82,7 +82,7 @@ void HTUpdateDefaultSetting(struct ieee80211_device *ieee)
>  
>  	// MIMO Power Save
>  	pHTInfo->SelfMimoPs = 3;// 0: Static Mimo Ps, 1: Dynamic Mimo Ps, 3: No Limitation, 2: Reserved(Set to 3 automatically.)
> -	if(pHTInfo->SelfMimoPs == 2)
> +	if (pHTInfo->SelfMimoPs == 2)
>  		pHTInfo->SelfMimoPs = 3;
>  	// 8190 only. Assign rate operation mode to firmware
>  	ieee->bTxDisableRateFallBack = 0;
> @@ -127,8 +127,7 @@ void HTDebugHTCapability(u8 *CapIE, u8 *TitleString )
>  	static u8	EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33};	// For 11n EWC definition, 2007.07.17, by Emily
>  	PHT_CAPABILITY_ELE		pCapELE;
>  
> -	if(!memcmp(CapIE, EWC11NHTCap, sizeof(EWC11NHTCap)))
> -	{
> +	if (!memcmp(CapIE, EWC11NHTCap, sizeof(EWC11NHTCap))) {

Like others have pointed out, this is something different than what you
are saying you are doing, please break this up into different patches.

thanks,

greg k-h


More information about the devel mailing list