[PATCH 2/3] staging: wilc1000: wilc_wlan_cfg_get(): replace integer with void pointer
Johnny Kim
johnny.kim at atmel.com
Fri Jul 10 08:11:11 UTC 2015
On 2015년 07월 10일 15:25, Julian Calaby wrote:
> Hi Johnny,
>
> On Fri, Jul 10, 2015 at 3:55 PM, Johnny Kim <johnny.kim at atmel.com> wrote:
>> Last argument of wilc_wlan_cfg_get function is actually structure's address.
>> This should be changed to be compatible with 64bit machine.
>> Because wilc_wlan_cfg_get function is mapped by function pointer later,
>> wilc_wlan_oup_t.wlan_cfg_get should be changed together.
>>
>> tstrWILC_WFIDrv structure is defined after wilc_wlan_oup_t.wlan_cfg_get
>> is defined. So, this patch changes the argument to void type pointer.
> Why not add a patch moving the structure definition before
> wilc_wlan_oup_t.wlan_cfg_get is defined?
Current patch focus on accessing 64bit address rightly.
The define order you and I mentioned should be repaired with another subject
because of complexity among files.
>> Signed-off-by: Johnny Kim <johnny.kim at atmel.com>
>> ---
>> drivers/staging/wilc1000/coreconfigurator.c | 2 +-
>> drivers/staging/wilc1000/wilc_wlan.c | 2 +-
>> drivers/staging/wilc1000/wilc_wlan_if.h | 2 +-
>> 3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
>> index b069614..141d7b4 100644
>> --- a/drivers/staging/wilc1000/coreconfigurator.c
>> +++ b/drivers/staging/wilc1000/coreconfigurator.c
>> @@ -2094,7 +2094,7 @@ s32 SendConfigPkt(u8 u8Mode, tstrWID *pstrWIDs,
>> (counter == u32WIDsCount - 1));
>> if (!gpstrWlanOps->wlan_cfg_get(!counter,
>> pstrWIDs[counter].u16WIDid,
>> - (counter == u32WIDsCount - 1), drvHandler)) {
>> + (counter == u32WIDsCount - 1), (void *)drvHandler)) {
> If I recall correctly, you shouldn't need void * casts.
>
> Thanks,
>
Thanks.
Johnny.
More information about the devel
mailing list