[PATCH 18/20] staging/lustre/libcfs: get rid of debugfs/lnet/debug_mb

[Dan Carpenter]

On Mon, Jul 06, 2015 at 12:48:56PM -0400, green at linuxhacker.ru wrote:
> +static int libcfs_param_debug_mb_set(const char *val,
> +				     const struct kernel_param *kp)
> +{
> +	int rc;
> +	unsigned num;
> +
> +	rc = kstrtouint(val, 0, &num);
> +	if (rc == -EINVAL)
> +		return -EINVAL;

Presumably, this is root only so using num uninitialized is not an
information leak.

> +
> +	if (!*((unsigned int *)kp->arg)) {
> +		*((unsigned int *)kp->arg) = num;
> +		return 0;
> +	}
> +
> +	rc = cfs_trace_set_debug_mb(num);
> +
> +	if (!rc)
> +		*((unsigned int *)kp->arg) = cfs_trace_get_debug_mb();
> +
> +	return rc;
> +}

regards,
dan carpenter