[PATCH] staging: vt6656: removed erroneous else statement

Greg Kroah-Hartman gregkh at linuxfoundation.org
Sat Jan 31 03:50:48 UTC 2015


On Fri, Jan 30, 2015 at 10:43:19PM -0500, Derrick Greenspan wrote:
> This patch fixes the checkpatch.pl warning:
> 
> WARNING: else is not generally useful after a break or return
> 559: FILE: drivers/staging/vt6656/rxtx.c:559:
> return vnt_rxtx_datahead_g_fb(tx_context, &buf->data_head);
> } else {
> 
> Signed-off-by: Derrick Greenspan <derrick.greenspan at knights.ucf.edu>
> ---
>  drivers/staging/vt6656/rxtx.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
> index b74f672..ae171cb 100644
> --- a/drivers/staging/vt6656/rxtx.c
> +++ b/drivers/staging/vt6656/rxtx.c
> @@ -556,7 +556,7 @@ static u16 vnt_fill_cts_head(struct vnt_usb_send_context *tx_context,
>  		ether_addr_copy(buf->data.ra, priv->current_net_addr);
>  
>  		return vnt_rxtx_datahead_g_fb(tx_context, &buf->data_head);
> -	} else {
> +	}
>  		struct vnt_cts *buf = &head->cts_g;
>  		/* Get SignalField,ServiceField,Length */
>  		vnt_get_phy_field(priv, cts_frame_len,
> @@ -574,7 +574,6 @@ static u16 vnt_fill_cts_head(struct vnt_usb_send_context *tx_context,
>  		ether_addr_copy(buf->data.ra, priv->current_net_addr);
>  
>  		return vnt_rxtx_datahead_g(tx_context, &buf->data_head);
> -	}

And now everything is at the incorrect indentation :(

Please fix properly.

thanks,

greg k-h


More information about the devel mailing list