[PATCH] staging: comedi: drivers: ni_atmio: Removed variables that is never used
Ian Abbott
abbotti at mev.co.uk
Thu Jan 29 14:44:07 UTC 2015
On 28/01/15 22:37, Rickard Strandqvist wrote:
> Variable ar assigned a value that is never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist at spectrumdigital.se>
> ---
> drivers/staging/comedi/drivers/ni_atmio.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c
> index 0c5ff28..301f154 100644
> --- a/drivers/staging/comedi/drivers/ni_atmio.c
> +++ b/drivers/staging/comedi/drivers/ni_atmio.c
> @@ -300,7 +300,6 @@ static int ni_atmio_attach(struct comedi_device *dev,
> struct comedi_devconfig *it)
> {
> const struct ni_board_struct *boardtype;
> - struct ni_private *devpriv;
> struct pnp_dev *isapnp_dev;
> int ret;
> unsigned long iobase;
> @@ -310,7 +309,6 @@ static int ni_atmio_attach(struct comedi_device *dev,
> ret = ni_alloc_private(dev);
> if (ret)
> return ret;
> - devpriv = dev->private;
>
> iobase = it->options[0];
> irq = it->options[1];
>
Yes, devpriv is no longer needed here.
Reviewed-by: Ian Abbott <abbotti at mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti at mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
More information about the devel
mailing list