[PATCH] staging: dgnc: fix long lines in PCI device table

Krzysztof Adamski k at japko.eu
Thu Jan 22 19:18:13 UTC 2015


On Thu, Jan 22, 2015 at 11:10:58AM -0800, Joe Perches wrote:
>On Thu, 2015-01-22 at 19:55 +0100, Krzysztof Adamski wrote:
>> This patch fixes coding style of PCI device table declaration.
>[]
>> diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
>[]
>> @@ -98,11 +98,11 @@ static struct timer_list dgnc_poll_timer;
>>
>>
>>  static struct pci_device_id dgnc_pci_tbl[] = {
>
>const
>
>> -	{	DIGI_VID, PCI_DEVICE_CLASSIC_4_DID, PCI_ANY_ID, PCI_ANY_ID, 0, 0,	0 },
>> -	{	DIGI_VID, PCI_DEVICE_CLASSIC_4_422_DID, PCI_ANY_ID, PCI_ANY_ID, 0, 0,	1 },
>> -	{	DIGI_VID, PCI_DEVICE_CLASSIC_8_DID, PCI_ANY_ID, PCI_ANY_ID, 0, 0,	2 },
>> -	{	DIGI_VID, PCI_DEVICE_CLASSIC_8_422_DID, PCI_ANY_ID, PCI_ANY_ID, 0, 0,	3 },
>> -	{0,}						/* 0 terminated list. */
>> +	{PCI_DEVICE(DIGI_VID, PCI_DEVICE_CLASSIC_4_DID), .driver_data = 0},
>> +	{PCI_DEVICE(DIGI_VID, PCI_DEVICE_CLASSIC_4_422_DID), .driver_data = 1},
>> +	{PCI_DEVICE(DIGI_VID, PCI_DEVICE_CLASSIC_8_DID), .driver_data = 2},
>> +	{PCI_DEVICE(DIGI_VID, PCI_DEVICE_CLASSIC_8_422_DID), .driver_data = 3},
>> +	{0,}
>
>Maybe better to keep the alignment of .driver_data
>
>+	{PCI_DEVICE(DIGI_VID, PCI_DEVICE_CLASSIC_4_DID),     .driver_data = 0},
>+	{PCI_DEVICE(DIGI_VID, PCI_DEVICE_CLASSIC_4_422_DID), .driver_data = 1},
>+	{PCI_DEVICE(DIGI_VID, PCI_DEVICE_CLASSIC_8_DID),     .driver_data = 2},
>+	{PCI_DEVICE(DIGI_VID, PCI_DEVICE_CLASSIC_8_422_DID), .driver_data = 3},
>

Good idea, looks better this way, I'll resend.


More information about the devel mailing list