[PATCH] staging: iio: ad5933: fix format string warnings

Lars-Peter Clausen lars at metafoo.de
Tue Jan 20 08:52:45 UTC 2015


On 01/20/2015 08:25 AM, Asaf Vertz wrote:
> Fixed the following warnings (reported by cppcheck):
> [drivers/staging/iio/impedance-analyzer/ad5933.c:363]: (warning) %d in format string (no. 1)
> requires 'int' but the argument type is 'unsigned int'.
> [drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 1)
> requires 'int' but the argument type is 'unsigned int'.
> [drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 2)
> requires 'int' but the argument type is 'unsigned int'.
> [drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 3)
> requires 'int' but the argument type is 'unsigned int'.
> [drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 4)
> requires 'int' but the argument type is 'unsigned int'.
>
> Signed-off-by: Asaf Vertz <asaf.vertz at tandemg.com>

Acked-by: Lars-Peter Clausen <lars at metafoo.de>

Thanks.

> ---
>   drivers/staging/iio/impedance-analyzer/ad5933.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c
> index b6bd609..4230a43 100644
> --- a/drivers/staging/iio/impedance-analyzer/ad5933.c
> +++ b/drivers/staging/iio/impedance-analyzer/ad5933.c
> @@ -360,11 +360,11 @@ static ssize_t ad5933_show(struct device *dev,
>   	mutex_lock(&indio_dev->mlock);
>   	switch ((u32) this_attr->address) {
>   	case AD5933_OUT_RANGE:
> -		len = sprintf(buf, "%d\n",
> +		len = sprintf(buf, "%u\n",
>   			      st->range_avail[(st->ctrl_hb >> 1) & 0x3]);
>   		break;
>   	case AD5933_OUT_RANGE_AVAIL:
> -		len = sprintf(buf, "%d %d %d %d\n", st->range_avail[0],
> +		len = sprintf(buf, "%u %u %u %u\n", st->range_avail[0],
>   			      st->range_avail[3], st->range_avail[2],
>   			      st->range_avail[1]);
>   		break;
>



More information about the devel mailing list