[PATCH v2 1/3] Drivers: hv: check vmbus_device_create() return value in vmbus_process_offer()

Dan Carpenter dan.carpenter at oracle.com
Mon Jan 19 18:03:01 UTC 2015


On Mon, Jan 19, 2015 at 08:58:58PM +0300, Dan Carpenter wrote:
> "error" is a crap label name because it doesn't tell you what the code
> does.  A better name is "err_free_chan" or something which talks about
> freeing the channel.

If you choose your label names correctly, then most of the time you can
just read the code from top to bottom and understand it without skipping
back and forth.

regards,
dan carpenter



More information about the devel mailing list