[PATCH 1/2] staging: olpc_dcon: check for CONFIG_OLPC before calling olpc_board_at_least()

Dan Carpenter dan.carpenter at oracle.com
Fri Jan 16 10:20:29 UTC 2015


On Thu, Jan 15, 2015 at 11:54:59PM -0200, Murilo Opsfelder Araujo wrote:
> The following error messages are thrown by sparse when CONFIG_OLPC is
> not defined:
> 
> drivers/staging/olpc_dcon/olpc_dcon.c:147:17: error: undefined identifier 'olpc_board_at_least'
> drivers/staging/olpc_dcon/olpc_dcon.c:208:14: error: undefined identifier 'olpc_board_at_least'
> 
> This patch fixes these errors.

Don't add ifdefs to a .c file.  Don't call BUG_ON() in a driver.

Figure out a better way to fix these.

regards,
dan carpenter



More information about the devel mailing list