[PATCH 01/30] staging: unisys: serverdown variable change bool to int virthba

gregkh at linuxfoundation.org gregkh at linuxfoundation.org
Fri Feb 27 01:17:01 UTC 2015


On Wed, Feb 11, 2015 at 05:41:13PM +0300, Dan Carpenter wrote:
> On Wed, Feb 11, 2015 at 08:32:52AM -0600, Romer, Benjamin M wrote:
> > On Wed, 2015-02-11 at 11:36 +0300, Dan Carpenter wrote:
> > > On Tue, Feb 10, 2015 at 12:58:35PM -0500, Benjamin Romer wrote:
> > > > From: Erik Arfvidson <erik.arfvidson at unisys.com>
> > > > 
> > > > This patch changes serverdown variable to int instead of bool
> > > > 
> > > 
> > > Why?  It looks like bool is more appropriate?
> > 
> > Hi Dan,
> > 
> > We had received some comments on our code that said that our BOOL
> > typedef wasn't acceptable,
> 
> Because we already have the "bool" type.

I agree with Dan here.  This is a bool type, so use it, only use int for
returning error values in functions, not for variables that really are
boolean values.

Can you respin this series with that change?

thanks,

greg k-h


More information about the devel mailing list